svn commit: r432561 - head/lang/php71
Torsten Zuehlsdorff
freebsd at toco-domains.de
Sun Jan 29 18:50:06 UTC 2017
On 27.01.2017 19:52, John Marino wrote:
> Author: marino
> Date: Fri Jan 27 18:52:24 2017
> New Revision: 432561
> URL: https://svnweb.freebsd.org/changeset/ports/432561
>
> Log:
> lang/php71: Bring DTRACE exclude for DF from lang/php70
>
> Maybe this would have been caught with SVN copy? Oh well.
>
> Approved by: just-fix-it
Its funny how "just-fix-it" often translate in "just-broke-it" - see
r432567.
But beside that back to being serious: why did nobody suggest a fix? If
repo-copy is this needed, we can do it right now?
svn rm lang/php71 && svn cp -r432321 lang/php70 lang/php71 && some files
copied would be all.
I took mat into CC because i want to know if something speaks against it
or if just nobody thought about it.
Also fun note: with an svn copy the DTRACE option wouldn't be included
too. I finished the patch 2 month ago, long before DTRACE was
introduced. So it wouldn't be there.
I just noted in this 2 month how hard it is to find somebody for review
and second how hard it is to get such a patch reviewed. First the
review.freebsd.org didn't work for me because it contains a bug with
umlaut for years. And second a repocopy could not be displayed.
So there is a wide field for human errors we should address. I have at
least some ideas about that.
Greetings,
Torsten
More information about the svn-ports-all
mailing list