svn commit: r448936 - in head/cad/stepcode: . files

[Baptiste Daroussin]

On Wed, Aug 30, 2017 at 09:31:00AM +0000, Alexey Dokuchaev wrote:
> On Tue, Aug 29, 2017 at 07:36:16PM +0000, Kurt Jaeger wrote:
> > New Revision: 448936
> > URL: https://svnweb.freebsd.org/changeset/ports/448936
> > 
> > Log:
> >   cad/stepcode: Fix portlint issues
> >   
> >   PR:		221835
> > ...
> >  CMAKE_ARGS+=	-DSC_INSTALL_PREFIX=${PREFIX} \
> >  		-DSC_BUILD_TYPE=Release
> > +
> > +MANDIRS=	${PREFIX}/man
> 
> What does this variable do?  I don't see it referenced anywhere.  Looks
> like someone tried to play pass MAN_DIR down to cmake, but failed to do
> it properly (see below).

This is used for auto compression of the manpages, see bsd.port.mk
In this case MANDIRS is completly useless as it is already default
> 
> > @@ -0,0 +1,11 @@
> > +--- doc/CMakeLists.txt.orig	2017-08-29 15:56:46 UTC
> > ++++ doc/CMakeLists.txt
> > +@@ -4,7 +4,7 @@ set(sc_MANS
> > +   )
> > + 
> > + if(NOT DEFINED MAN_DIR)
> > +-  set(MAN_DIR share/man)
> > ++  set(MAN_DIR man)
> > + endif(NOT DEFINED MAN_DIR)
> 
> Why to patch it when you can pass MAN_DIR via CMAKE_ARGS (together with
> other values)?

+1

Bapt
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20170830/7ab6b2f4/attachment-0001.sig>