svn commit: r448747 - in head/mail: . smfsav smfsav-devel smfsav-devel/files

[Mathieu Arnold]

Le 26/08/2017 à 03:18, Danilo G. Baio a écrit :
>  PLIST_SUB=	SMFSAV_RUN_DIR=${SMFSAV_RUN_DIR}
>  SUB_FILES+=	pkg-message
> +SUB_LIST=	${PLIST_SUB}

This is a very bad idea, it does not do what you think it does.

$ make -V SUB_LIST
SMFSAV_RUN_DIR=/var/run/smfs OSREL=11.1 PREFIX=%D LOCALBASE=/usr/local 
RESETPREFIX=/usr/local PORTDOCS="" PORTEXAMPLES="" LIB32DIR=lib
DOCSDIR="share/doc/smfsav"  EXAMPLESDIR="share/examples/smfsav" 
DATADIR="share/smfsav"  WWWDIR="www/smfsav"  ETCDIR="etc/smfsav"
PREFIX=/usr/local LOCALBASE=/usr/local  DATADIR=/usr/local/share/smfsav
DOCSDIR=/usr/local/share/doc/smfsav
EXAMPLESDIR=/usr/local/share/examples/smfsav 
WWWDIR=/usr/local/www/smfsav ETCDIR=/usr/local/etc/smfsav

Now, you have two instances of many variables in there, for example:

$ make -V SUB_LIST:METCDIR*
ETCDIR="etc/smfsav" ETCDIR=/usr/local/etc/smfsav


It is completely unsupported, and I am quite sure it would likely break
very badly.

A quick fix would be to change = by :=, but := sometime does other
things that you do not expect. It would probably be better to dupplicate
the content.


-- 
Mathieu Arnold


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 949 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20170826/83b20cf7/attachment.sig>