svn commit: r448704 - in head/games: . openrct2 openrct2/files

[Mathieu Arnold]

Le 24/08/2017 à 21:22, Dmitry Marakasov a écrit :
> +PORTNAME=	openrct2
> +DISTVERSIONPREFIX=	v
> +DISTVERSION=	0.1.1
> +CATEGORIES=	games
> +EXTRACT_ONLY=	${PORTNAME}-${PORTNAME}-${DISTVERSIONPREFIX}${DISTVERSION}_GH0${EXTRACT_SUFX}

So, the whole first part is called ${DISTNAME} and you are hardcoding
implementation details of USE_GITHUB. Also the last part is wrong,
EXTRACT_SUFX can be changed, with various USES, whereas USE_GITHUB
always use _GITHUB_EXTRACT_SUFX.

Also, it is the only distfile, so the EXTRACT_ONLY line is useless.

> +WRKSRC=		${WRKDIR}/OpenRCT2-${PORTVERSION}

WRKSRC is always correct when using USE_GITHUB. If you feel like you
need to change it, use GH_PROJECT= OpenRCT2 instead.

> Added: head/games/openrct2/files/pkg-message.in
> ==============================================================================
> --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> +++ head/games/openrct2/files/pkg-message.in	Thu Aug 24 19:22:07 2017	(r448704)
> @@ -0,0 +1,10 @@
> +================================================================================
> +
> +To complete the installation of this port, you need to download the file
> +https://github.com/OpenRCT2/title-sequences/releases/download/%%DISTVERSIONPREFIX%%%%DISTVERSION%%/title-sequence-%%DISTVERSIONPREFIX%%%%DISTVERSION%%.zip
> +and unpack it to %%PREFIX%%/share/%%PORTNAME%%/title.
> +
> +You need to follow https://openrct2.website/getting-started/index.html
> +to finish installation.
> +
> +================================================================================

Is there some kind of licensing issue that makes it impossible for the
port to install the files it needs ?


-- 
Mathieu Arnold


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 949 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20170825/c5872379/attachment.sig>