svn commit: r429481 - in head: . x11 x11/lightdm x11/lightdm-gtk-greeter x11/lightdm/files

[Jan Beich]

jbeich at freebsd.org (Jan Beich) writes:

>> --- /dev/null	00:00:00 1970	(empty, because file is newly added)
>> +++ head/x11/lightdm/files/patch-src_process.c	Mon Dec 26 06:53:37 2016	(r429481)
>> @@ -0,0 +1,11 @@
>> +--- src/process.c.orig	2016-12-08 21:38:14 UTC
>> ++++ src/process.c
>> +@@ -231,7 +231,7 @@ process_start (Process *process, gboolea
>> + #ifdef HAVE_CLEARENV
>> +             clearenv ();
>> + #else
>> +-            environ = NULL;
>> ++            putenv ("environ=NULL");
>> + #endif
>> +         for (i = 0; i < env_length; i++)
>> +             setenv (env_keys[i], env_values[i], TRUE);
>
> Looks bogus, see environ(7). Maybe use "env -i" version:
>
>   extern char **environ;
>   char *cleanenv[1];
>   environ = cleanenv;
>   cleanenv[0] = NULL;

Did you ignore this despite possible security implications? I'm not a user,
so just guessing.