svn commit: r426722 - in head/lang: . pocl pocl/files

[Koop Mast]

On Mon, 2016-11-21 at 19:33 +0100, Mathieu Arnold wrote:
> Le 21/11/2016 à 15:36, Koop Mast a écrit :
> > 
> > +#USES=		autoreconf gmake localbase pathfix pkgconfig
> > libtool
> > +USES=		gmake localbase ncurses pathfix pkgconfig
> > libtool:keepla
> > +
> > +#CONFIGURE_ARGS+=	--enable-pedantic
> Commented out lines in Makefiles makes you wonder about the quality
> of
> the submission, wether it is a work in progress, or a final patch

This is all mine, I did a once over before commit but I missed those
commented lines.

> > 
> > +do-test:
> > +	cd ${WRKSRC} && ${GMAKE} check
> NEVER use GMAKE, it is always called MAKE_CMD. Also, all this should
> be
> written as:
> 
> TEST_TARGET=    check

I thik I looked up MAKE_CMD once but I don't use this that often so I
probably forgot about that. I will try to keep it in mind for the next
time. I didn't know about TEST_TARGET existence.

These problems have been corrected, thanks for your comments!

-Koop