svn commit: r409855 - in head: lang/tcl86 lang/tcl86/files x11-toolkits/tk86

[Pietro Cerutti]

On 2016-03-01 10:58, Mathieu Arnold wrote:
> +--On 1 mars 2016 09:31:43 +0000 Pietro Cerutti <gahr at FreeBSD.org> 
> wrote:
> | +TEST_TARGET=	do-test
> 
> That should not be needed, the fact that you have a do-test target will
> have "make test" work the right way.
> 
> | +TCLMAN_VARS=	INSTALL_TARGET+=install-doc
> | +TZDATA_VARS=	INSTALL_TARGET+=install-tzdata
> | +MODULES_VARS=	INSTALL_TARGET+=install-modules
> 
> These three should be written as:
> 
> TCLMAN_INSTALL_TARGET=install-doc
> TZDATA_INSTALL_TARGET=install-tzdata
> MODULES_INSTALL_TARGET=install-modules
> 
> instead of using the _VARS construct.  The porter's handbook do say, in 
> red:
> 
>         Before using OPT_VARS and OPT_VARS_OFF, see if there is already 
> a
>         more specific helper available
> 
> With a link to the correct section.
> 
> | +.include <bsd.port.options.mk>
> 
> You can drop this if you use the post-patch-TCLMAN-off: target.

All applied, thank you!

-- 
Pietro Cerutti
gahr at FreeBSD.org