svn commit: r416802 - in branches/2016Q2/security/sudo: . files

[Renato Botelho]

Author: garga
Date: Sun Jun 12 13:21:20 2016
New Revision: 416802
URL: https://svnweb.freebsd.org/changeset/ports/416802

Log:
  MFH: r416751
  
  Add a patch to fix sudo bug #743 that causes a bug where it dereference
  a NULL pointer when it looks up a negative cached entry which is stored
  as a NULL passwd or group struct pointer
  
  PR:		208198
  Submitted by:	Fredrik Eriksson <fredrik.eriksson at loopia.se>
  Obtained from:	https://www.sudo.ws/repos/sudo/rev/1d13341d53ec
  Sponsored by:	Rubicon Communications (Netgate)
  Approved by:	ports-secteam (feld)

Added:
  branches/2016Q2/security/sudo/files/patch-fix_bz208198
     - copied unchanged from r416751, head/security/sudo/files/patch-fix_bz208198
Modified:
  branches/2016Q2/security/sudo/Makefile
Directory Properties:
  branches/2016Q2/   (props changed)

Modified: branches/2016Q2/security/sudo/Makefile
==============================================================================
--- branches/2016Q2/security/sudo/Makefile	Sun Jun 12 13:19:55 2016	(r416801)
+++ branches/2016Q2/security/sudo/Makefile	Sun Jun 12 13:21:20 2016	(r416802)
@@ -3,6 +3,7 @@
 
 PORTNAME=	sudo
 PORTVERSION=	1.8.16
+PORTREVISION=	1
 CATEGORIES=	security
 MASTER_SITES=	SUDO
 

Copied: branches/2016Q2/security/sudo/files/patch-fix_bz208198 (from r416751, head/security/sudo/files/patch-fix_bz208198)
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ branches/2016Q2/security/sudo/files/patch-fix_bz208198	Sun Jun 12 13:21:20 2016	(r416802, copy of r416751, head/security/sudo/files/patch-fix_bz208198)
@@ -0,0 +1,35 @@
+--- plugins/sudoers/pwutil.c	Thu Apr 28 15:27:53 2016 -0600
++++ plugins/sudoers/pwutil.c	Wed May 04 08:55:21 2016 -0600
+@@ -139,8 +139,8 @@
+ 	item = node->data;
+ 	sudo_debug_printf(SUDO_DEBUG_DEBUG,
+ 	    "%s: uid %u [%s] -> user %s [%s] (cache hit)", __func__,
+-	    (unsigned int)uid, key.registry, item->d.pw->pw_name,
+-	    item->registry);
++	    (unsigned int)uid, key.registry,
++	    item->d.pw ? item->d.pw->pw_name : "unknown", item->registry);
+ 	goto done;
+     }
+     /*
+@@ -202,8 +202,8 @@
+     if ((node = rbfind(pwcache_byname, &key)) != NULL) {
+ 	item = node->data;
+ 	sudo_debug_printf(SUDO_DEBUG_DEBUG,
+-	    "%s: user %s [%s] -> uid %u [%s] (cache hit)", __func__, name,
+-	    key.registry, (unsigned int)item->d.pw->pw_uid, item->registry);
++	    "%s: user %s [%s] -> uid %d [%s] (cache hit)", __func__, name,
++	    key.registry, item->d.pw ? (int)item->d.pw->pw_uid : -1, item->registry);
+ 	goto done;
+     }
+     /*
+@@ -461,8 +461,8 @@
+ 	item = node->data;
+ 	sudo_debug_printf(SUDO_DEBUG_DEBUG,
+ 	    "%s: gid %u [%s] -> group %s [%s] (cache hit)", __func__,
+-	    (unsigned int)gid, key.registry, item->d.gr->gr_name,
+-	    item->registry);
++	    (unsigned int)gid, key.registry,
++	    item->d.gr ? item->d.gr->gr_name : "unknown", item->registry);
+ 	goto done;
+     }
+     /*