svn commit: r418403 - in head/mail: . jwsmtp

[Alexey Dokuchaev]

On Mon, Jul 11, 2016 at 08:14:30PM +0000, Kurt Jaeger wrote:
> New Revision: 418403
> URL: https://svnweb.freebsd.org/changeset/ports/418403

Kurt,

> Log:
>   New port: mail/jwsmtp
>   [...]
>   
> +NO_OPTIONS_SORT=	yes

May I ask what's the point of this line in this particular case?

> +OPTIONS_DEFINE=		DOCS MANPAGES
> +OPTIONS_DEFAULT=	DOCS MANPAGES

DOCS is already in the default option set, no need to put it here again.
And we normally do not conditionalize manpages unless they are actually
being *built* with some heavy stuff like LaTeX or something.

Notice that in r416385 you've made a similar mistake of putting IPV6 on
default options list.  Please review `Mk/bsd.options.mk' to see what how
this list is being initialized.

> +DOCS_DESC=	Install documentation
> +MANPAGES_DESC=	Install manpages

We have both definitions in the default pull; "manpages" is more of a
slang form (should've been spelled as "manual pages" in this context),
but then again -- manpages should be just intalled, no option needed.

> +.if ${PORT_OPTIONS:MDOCS}
> +PLIST_SUB+=	PORTDOCS=""
> +.else
> +PLIST_SUB+=	PORTDOCS="@comment "
> +.endif
> +
> +.if ${PORT_OPTIONS:MMANPAGES}
> +PLIST_SUB+=	MANPAGES=""
> +.else
> +PLIST_SUB+=	MANPAGES="@comment "
> +.endif

OPTIONS_SUB would've saved you the trouble here.

./danfe