svn commit: r400154 - in head/ports-mgmt/portlint: . src

[Bryan Drewery]

On 10/26/15 7:35 AM, Joe Marcus Clarke wrote:
> On 10/26/15 04:47, Alexey Dokuchaev wrote:
>> On Sun, Oct 25, 2015 at 05:27:38PM +0000, Joe Marcus Clarke wrote:
>>> New Revision: 400154
>>> URL: https://svnweb.freebsd.org/changeset/ports/400154
>>>
>>> Log:
>>>    Update to 2.16.7.
>>>
>>>    * Remove the check for USES being sorted.  Order is important. [2]
>>>    PR:        203908 [2]
>>
>> PR fails to provide any specifics though.  USES should be order-agnostic;
>> dependencies should be specified explicitly.  Sorted USES might actually
>> help to find those bugs (any are known?) and fix them quickly.
>>
>> Relying on a specific USES order is a bug.
>>
>> ./danfe
>>
> 
> This is why I left the code commented out instead of removing it
> outright.  This clearly needs more discussion.
> 
> Bryan, care to fill us in?
> 
> Joe
> 

Here's just 1 example:

~/svn/ports/Mk/Uses # grep ^MAKE_CMD= *
fmake.mk:MAKE_CMD=              ${FMAKE}
gmake.mk:MAKE_CMD=              gmake${_GMAKE_EXT}
ninja.mk:MAKE_CMD=      ninja
scons.mk:MAKE_CMD=              ${SCONS}
waf.mk:MAKE_CMD=        ${PYTHON_CMD} ${WAF_CMD}

The last one wins.

There are likely other cases too, sorting for the sake of sorting is not
safe.

-- 
Regards,
Bryan Drewery