svn commit: r398821 - head/security/maia

[Dmitry Marakasov]

* Baptiste Daroussin (bapt at FreeBSD.org) wrote:

> > Author: amdmi3
> > Date: Thu Oct  8 13:19:42 2015
> > New Revision: 398821
> > URL: https://svnweb.freebsd.org/changeset/ports/398821
> > 
> > Log:
> >   - Move file owner handling to plist, fix stage as non-root
> >   
> >   PR:		203287
> >   Submitted by:	amdmi3
> >   Approved by:	maintainer timeout (ek at purplehat.org, 2 weeks)
> > 
> > Modified:
> >   head/security/maia/Makefile
> >   head/security/maia/pkg-plist
> > 
> > Modified: head/security/maia/Makefile
> > ==============================================================================
> > --- head/security/maia/Makefile	Thu Oct  8 12:56:37 2015	(r398820)
> > +++ head/security/maia/Makefile	Thu Oct  8 13:19:42 2015	(r398821)
> > @@ -338,7 +338,6 @@ post-patch:
> >  do-install:
> >  	${MKDIR} ${STAGEDIR}${WWWDIR}
> >  	@cd ${WRKSRC}/php && ${COPYTREE_SHARE} . ${STAGEDIR}${WWWDIR}
> > -	${CHOWN} -R ${WWWOWN}:${WWWGRP} ${STAGEDIR}${WWWDIR}/
> >  	${LN} -s ${PREFIX}/share/smarty ${STAGEDIR}${WWWDIR}/libs/Smarty
> >  	${MKDIR} -p ${STAGEDIR}${DATADIR}
> >  	@cd ${WRKSRC}/scripts && ${COPYTREE_SHARE} . ${STAGEDIR}${DATADIR}/scripts
> > @@ -350,11 +349,10 @@ do-install:
> >  	${INSTALL} -m 640 ${WRKSRC}/maiad.conf.dist ${STAGEDIR}${ETCDIR}/maiad.conf.dist
> >  	${INSTALL} -m 640 ${WRKSRC}/maia.conf.dist ${STAGEDIR}${ETCDIR}/maia.conf.dist
> >  
> > -.if ${PORT_OPTIONS:MDOCS}
> > +do-install-DOCS-on:
> >  	${MKDIR} ${STAGEDIR}${DOCSDIR}
> >  .for i in ${DOCS}
> >  	${INSTALL_DATA} ${WRKSRC}/${i} ${STAGEDIR}${DOCSDIR}
> >  .endfor
> > -.endif
> >  
> >  .include <bsd.port.post.mk>
> > 
> > Modified: head/security/maia/pkg-plist
> > ==============================================================================
> > --- head/security/maia/pkg-plist	Thu Oct  8 12:56:37 2015	(r398820)
> > +++ head/security/maia/pkg-plist	Thu Oct  8 13:19:42 2015	(r398821)
> > @@ -40,6 +40,8 @@ sbin/maiad
> >  %%DATADIR%%/scripts/send-quarantine-reminders.pl
> >  %%DATADIR%%/scripts/stats-snapshot.pl
> >  @mode
> > + at owner %%WWWOWN%%
> > + at group %%WWWGRP%%
> 
> There is absolutly no reason those files belongs to those users only directories
> (like cache directories) and files that the app expect to be able to modified
> when run should be own by such user, otherwise everything should belong to
> root/wheel: aka the default

I know, and there's ton of ports like that. However my task currently is
to fix stage-qa problems and packaging as non-root, so I do not change
owner/group scope. Permissions should be fixed by maintainers.

-- 
Dmitry Marakasov   .   55B5 0596 FF1E 8D84 5F56  9510 D35A 80DD F9D2 F77D
amdmi3 at amdmi3.ru  ..:  jabber: amdmi3 at jabber.ru      http://amdmi3.ru