svn commit: r400565 - head/security/pam_krb5

[Cy Schubert]

In message <20151104.083641.2117830857202894349.hrs at allbsd.org>, Hiroki 
Sato wr
ites:
> Cy Schubert <Cy.Schubert at komquats.com> wrote
>   in <201511030457.tA34vkf5040066 at slippy.cwsent.com>:
> 
> Cy> In message <56377C39.5000401 at marino.st>, John Marino writes:
> Cy> > We don't have to settle for what it is.  We can control the build flags
> .
> Cy> >
> Cy> > The bottom line is that a regression happened.  If the current makefile
> Cy> > can't be fixed to operate as it was before, the change should be
> Cy> > reverted, right?
> Cy>
> Cy> Actually, it never worked in the first place. That is because the heimdal
> Cy> port puts its include files in ${LOCALBASE}/include/heimdal (take note of
> Cy> "heimdal" at the end of the path) and libraries in ${LOCALBASE}/lib/heimd
> al
> Cy> (same as above). Ldd ${LOCALBASE}/lib/security/pam_krb5.so makes that
> Cy> abundantly clear.
> Cy>
> Cy> Having said that, it's still no reason or excuse for it not to work. Test
> ed
> Cy> in a virgin jail, it's working now, and committed. Sorry about the
> Cy> confusion.
> 
>  Can you please use the pre-defined variables for them instead of
>  hardcoded pathnames?  Pathnames for headers and libraries are defined
>  as GSSAPIINCDIR and GSSAPILIBDIR in gssapi.mk in an
>  implementation-neutral way (and "flags" modifier like
>  "gssapi:heimdal,flags" imports them into CFLAGS and LDFLAGS if
>  necessary).  Tests for KRB5_HOME and HEIMDAL_HOME should also be
>  replaced with GSSAPIBASEDIR.  I confirmed that the attached patch
>  worked fine.

Thanks for the patch. It's a lot neater. Committed.


-- 
Cheers,
Cy Schubert <Cy.Schubert at komquats.com> or <Cy.Schubert at cschubert.com>
FreeBSD UNIX:  <cy at FreeBSD.org>   Web:  http://www.FreeBSD.org

	The need of the many outweighs the greed of the few.