svn commit: r386285 - head/security/keychain

[Sunpoet Po-Chuan Hsieh]

On Fri, May 15, 2015 at 12:03 AM, Bryan Drewery <bdrewery at freebsd.org>
wrote:

> On 5/14/2015 11:00 AM, Adam Weinberger wrote:
> >> On 13 May, 2015, at 21:20, Philip M. Gollucci <pgollucci at p6m7g8.com>
> wrote:
> >>
> >> Then it needs an option not an if exists()
> >
> > Bryan, can you please consider reverting it, or giving me approval to
> revert it? It may fix the case when the port is built in poudriere without
> sshd in base, but it is a regression for everybody else.
> >
> > # Adam
> >
> >
>
> No. The way RUN_DEPENDS is supposed to work is what I said in the
> commit. These exists() checks are redundant and confuse the package
> dependencies.
>
> How are you building? It's possible the tool you are using is
> incorrectly handling RUN_DEPENDS.
>
> --
> Regards,
> Bryan Drewery
>
>
I could confirm that keychain 2.8.0_2 will not bring in openssh-portable if
you have ssh-agent in base.
But 'make run-depends-list' will give you incorrect result.

Regards,
sunpoet

% make install
===>  Installing for keychain-2.8.0_2
===>   keychain-2.8.0_2 depends on file: /usr/local/bin/bash - found
===>   keychain-2.8.0_2 depends on executable: ssh-agent - found
===>  Checking if keychain already installed
actual-package-depends: dependency on /usr/bin/ssh-agent not registered
(normal if it belongs to base)
===>   Registering installation for keychain-2.8.0_2
Installing keychain-2.8.0_2...

% pkg info -dx keychain
keychain-2.8.0_2:
        bash-4.3.33

% make run-depends-list
/usr/ports/security/openssh-portable
/usr/ports/shells/bash