svn commit: r386285 - head/security/keychain

[Bryan Drewery]

On 5/14/2015 11:03 AM, Bryan Drewery wrote:
> On 5/14/2015 11:00 AM, Adam Weinberger wrote:
>>> On 13 May, 2015, at 21:20, Philip M. Gollucci <pgollucci at p6m7g8.com> wrote:
>>>
>>> Then it needs an option not an if exists()
>>
>> Bryan, can you please consider reverting it, or giving me approval to revert it? It may fix the case when the port is built in poudriere without sshd in base, but it is a regression for everybody else.
>>
>> # Adam
>>
>>
> 
> No. The way RUN_DEPENDS is supposed to work is what I said in the
> commit. These exists() checks are redundant and confuse the package
> dependencies.
> 
> How are you building? It's possible the tool you are using is
> incorrectly handling RUN_DEPENDS.
> 

Poudriere testport -i confirms this:

> =======================<phase: package        >============================
> ===>  Building package for keychain-2.8.0_2
> actual-package-depends: dependency on /usr/bin/ssh-agent not registered (normal if it belongs to base)
...
> root at exp-10amd64-commit-test:~ # pkg info | grep openssh
> root at exp-10amd64-commit-test:~ #

The ports framework, and poudriere, properly do not actually add this
dependency and install it.

Poudriere however does incorrectly *build* openssh-portable, but it
won't add it as a real package run dependency.



-- 
Regards,
Bryan Drewery

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20150514/7661ee6a/attachment.sig>