svn commit: r385776 - in head/sysutils: . rubygem-hiera-file

[Philip M. Gollucci]

Its also documented in the PBH to do what portlint says.  I like the
consistency but have no overall opinion.

On Fri, May 8, 2015 at 12:03 PM, Bryan Drewery <bdrewery at freebsd.org> wrote:

> On 5/8/2015 11:00 AM, Mathieu Arnold wrote:
> > +--On 8 mai 2015 10:53:12 -0500 Bryan Drewery <bdrewery at FreeBSD.org>
> wrote:
> > |>
> > |> % portlint -abct
> > |> WARN: Makefile: Consider defining LICENSE.
> > |> WARN: Makefile: "RUN_DEPENDS" has to appear earlier.
> > |> 0 fatal errors and 2 warnings found.
> > |
> > | This rule serves no purpose.
> >
> > I don't really agree, from make's point of view, it does not, but from
> the
> > point of view of us all having to maintain a bunch of Makefiles, if the
> > order of the group of fields is always consistent, it's easier to read.
> >
>
> But it's not, and it's not possible to do so. Consider OPTION-based
> DEPENDS. See www/nginx/Makefile as an example. This rule will never be
> consistent and it's a pointless rule that serves only to annoy people.
>
> --
> Regards,
> Bryan Drewery
>
>


-- 
---------------------------------------------------------------------------------
Curb: Your ride is here
4096R/D1EAB94D 2081 E230 3001 6508 8847  1BBF A0A8 DB0F D1EA B94D
Philip M. Gollucci (pgollucci at p6m7g8.com) c: 703.336.9354
Member,                           Apache Software Foundation
Committer,                        FreeBSD Foundation
Consultant,                       P6M7G8 Inc.
Sr. Director IT Operations,       Curb

What doesn't kill us can only make us stronger;
Except it almost kills you.