svn commit: r385776 - in head/sysutils: . rubygem-hiera-file

[Matthew Seaman]

On 2015/05/08 16:53, Bryan Drewery wrote:
> On 5/8/2015 10:43 AM, Sunpoet Po-Chuan Hsieh wrote:
>> On Fri, May 8, 2015 at 11:31 PM, Bryan Drewery <bdrewery at freebsd.org
>> <mailto:bdrewery at freebsd.org>> wrote:
>>
>>     On 5/8/2015 9:45 AM, Sunpoet Po-Chuan Hsieh wrote:
>>     > On Fri, May 8, 2015 at 9:05 PM, Matthew Seaman <matthew at freebsd.org <mailto:matthew at freebsd.org>
>>     > <mailto:matthew at freebsd.org <mailto:matthew at freebsd.org>>> wrote:
>>     >
>>     >     Author: matthew
>>     >     Date: Fri May  8 13:05:29 2015
>>     >     New Revision: 385776
>>     >     URL: https://svnweb.freebsd.org/changeset/ports/385776
>>     >
>>     >     Log:
>>     >       A data backend for Hiera that can return the content of
>>     whole files.
>>     >
>>     >       WWW: https://github.com/adrienthebo/hiera-file
>>     >
>>     >     Added:
>>     >       head/sysutils/rubygem-hiera-file/
>>     >       head/sysutils/rubygem-hiera-file/Makefile   (contents, props
>>     changed)
>>     >       head/sysutils/rubygem-hiera-file/distinfo   (contents, props
>>     changed)
>>     >       head/sysutils/rubygem-hiera-file/pkg-descr   (contents,
>>     props changed)
>>     >     Modified:
>>     >       head/sysutils/Makefile
>>     >
>>     >     Modified: head/sysutils/Makefile
>>     >   
>>      ==============================================================================
>>     >     --- head/sysutils/Makefile      Fri May  8 13:02:39 2015
>>     >     (r385775)
>>     >     +++ head/sysutils/Makefile      Fri May  8 13:05:29 2015
>>     >     (r385776)
>>     >     @@ -836,6 +836,7 @@
>>     >          SUBDIR += rubygem-hammer_cli_foreman_salt
>>     >          SUBDIR += rubygem-hammer_cli_foreman_ssh
>>     >          SUBDIR += rubygem-hiera
>>     >     +    SUBDIR += rubygem-hiera-file
>>     >          SUBDIR += rubygem-librarian-puppet
>>     >          SUBDIR += rubygem-log4r
>>     >          SUBDIR += rubygem-logify
>>     >
>>     >     Added: head/sysutils/rubygem-hiera-file/Makefile
>>     >   
>>      ==============================================================================
>>     >     --- /dev/null   00:00:00 1970   (empty, because file is newly
>>     added)
>>     >     +++ head/sysutils/rubygem-hiera-file/Makefile   Fri May  8
>>     13:05:29
>>     >     2015        (r385776)
>>     >     @@ -0,0 +1,18 @@
>>     >     +# Created by: Matthew Seaman <matthew at FreeBSD.org>
>>     >     +# $FreeBSD$
>>     >     +
>>     >     +PORTNAME=      hiera-file
>>     >     +PORTVERSION=   1.1.1
>>     >     +CATEGORIES=    sysutils rubygems
>>     >     +MASTER_SITES=  RG
>>     >     +
>>     >     +MAINTAINER=    matthew at FreeBSD.org
>>     >     +COMMENT=       Data backend for Hiera that returns whole files
>>     >     +
>>     >     +USE_RUBY=      yes
>>     >     +USE_RUBYGEMS=  yes
>>     >     +RUBYGEM_AUTOPLIST=     yes
>>     >     +
>>     >     +RUN_DEPENDS=
>>     >      ${PKGNAMEPREFIX}hiera>=0:${PORTSDIR}/sysutils/rubygem-hiera
>>     >
>>     >
>>     > RUN_DEPENDS should appear earlier. :)
>>     >
>>
>>     Why?
>>
>>
>> % portlint -abct
>> WARN: Makefile: Consider defining LICENSE.
>> WARN: Makefile: "RUN_DEPENDS" has to appear earlier.
>> 0 fatal errors and 2 warnings found.
> 
> This rule serves no purpose.

The port was pretty much cut'n'paste from sysutils/rubygem-hiera.
Besides, where in the Makefile would be considered suitable by portlint?
 Above all the USE_FOO= stuff?  That's going to generate even worse
complaints.

Oh, I get it.  It thinks the RUBYGEM_AUTOPLIST line should occur later.
 Except that the rational place to put that is right next to the
'USE_RUBYGEMS' line.

portlint isn't guarranteed to be perfect, and in this case, I think it
is complaining unnecessarily.

	Cheers,

	Matthew



-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 1012 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20150508/f00ef7aa/attachment.sig>