svn commit: r382338 - head/devel/hub

[Sunpoet Po-Chuan Hsieh]

On Fri, Mar 27, 2015 at 3:33 AM, Steve Wills <swills at freebsd.org> wrote:

> Author: swills
> Date: Thu Mar 26 19:33:35 2015
> New Revision: 382338
> URL: https://svnweb.freebsd.org/changeset/ports/382338
> QAT: https://qat.redports.org/buildarchive/r382338/
>
> Log:
>   devel/hub: update to 2.2.0
>
>   PR:           197999
>   Submitted by: swills (myself)
>   Approved by:  koukopoulos at gmail.com (maintainer)
>
> Modified:
>   head/devel/hub/Makefile
>   head/devel/hub/distinfo
>
> Modified: head/devel/hub/Makefile
>
> ==============================================================================
> --- head/devel/hub/Makefile     Thu Mar 26 19:24:15 2015        (r382337)
> +++ head/devel/hub/Makefile     Thu Mar 26 19:33:35 2015        (r382338)
> @@ -2,7 +2,7 @@
>  # $FreeBSD$
>
>  PORTNAME=      hub
> -PORTVERSION=   1.12.2
> +PORTVERSION=   2.2.0
>  CATEGORIES=    devel
>
>  MAINTAINER=    koukopoulos at gmail.com
> @@ -12,22 +12,27 @@ LICENSE=    MIT
>
>  USE_GITHUB=    yes
>  GH_ACCOUNT=    github
> -GH_TAGNAME=    v${DISTVERSION}
> -GH_COMMIT=     9016a39
>
> -USE_RUBY=      yes
> -USE_RAKE=      yes
> +DISTVERSIONPREFIX=v
> +
> +MASTER_SITES=   GH
> +
> +BUILD_DEPENDS= go:${PORTSDIR}/lang/go \
> +               bash:${PORTSDIR}/shells/bash
> +
> +WRKSRC=                ${WRKDIR}/${PORTNAME}-${PORTVERSION}
> +
> +STRIP=         # stripping can break go binaries
>
>  PLIST_FILES=   bin/hub \
>                 etc/bash_completion.d/hub \
>                 share/zsh/site-functions/_hub \
>                 man/man1/hub.1.gz
> -
>  do-build:
> -       @cd ${WRKSRC} && ${RAKE_BIN} standalone
> +       @cd ${WRKSRC} ; ${SETENV} ${LOCALBASE}/bin/bash script/build
>
>  do-install:
> -       ${INSTALL_SCRIPT} ${WRKSRC}/hub ${STAGEDIR}${PREFIX}/bin
> +       ${INSTALL_PROGRAM} ${WRKSRC}/hub ${STAGEDIR}${PREFIX}/bin
>         ${INSTALL_MAN} ${WRKSRC}/man/hub.1
> ${STAGEDIR}${MAN1PREFIX}/man/man1
>         @${MKDIR} ${STAGEDIR}${PREFIX}/etc/bash_completion.d
>         ${INSTALL_DATA} ${WRKSRC}/etc/hub.bash_completion.sh
> ${STAGEDIR}${PREFIX}/etc/bash_completion.d/hub
>
> Modified: head/devel/hub/distinfo
>
> ==============================================================================
> --- head/devel/hub/distinfo     Thu Mar 26 19:24:15 2015        (r382337)
> +++ head/devel/hub/distinfo     Thu Mar 26 19:33:35 2015        (r382338)
> @@ -1,2 +1,2 @@
> -SHA256 (hub-1.12.2.tar.gz) =
> 98003caa613ae94fffd6611f1f3e9b58d906349d0579b8aca16f137cb13a5347
> -SIZE (hub-1.12.2.tar.gz) = 76606
> +SHA256 (hub-v2.2.0_GH0.tar.gz) =
> 2da1351197eb5696c207f22c69a5422af052d74277b73d0b8661efb9ec1d0eb1
> +SIZE (hub-v2.2.0_GH0.tar.gz) = 301460
>
>
Hi Steve,

I have several suggestions:
- With r382120, I think GH_TAGNAME=v${PORTVERSION} is better than
DISTVERSIONPREFIX=v.
- MASTER_SITES can be removed if github.com is the only master site.
USE_GITHUB will handle it.
- To pet portlint, move BUILD_DEPENDS after the LICENSE section.

Here's my patch at https://people.freebsd.org/~sunpoet/hub.patch

Regards,
sunpoet