svn commit: r382100 - in head: archivers/pixz archivers/pixz/files dns/dualserver french/aster japanese/scim-skk news/nzbget ports-mgmt/bpm sysutils/freeipmi x11-wm/libcompizconfig

[John Marino]

On 3/24/2015 19:31, Thierry Thomas wrote:
>> Modified: head/french/aster/Makefile
>> ==============================================================================
>> --- head/french/aster/Makefile	Tue Mar 24 13:43:16 2015	(r382099)
>> +++ head/french/aster/Makefile	Tue Mar 24 13:51:17 2015	(r382100)
>> @@ -252,9 +252,9 @@ pre-configure:
>>  	${ECHO_CMD} "F90='${FC}'"				>> ${WRKSRC}/setup.cfg
>>  	${ECHO_CMD} "MATHLIB='${lib_math} ${LDFLAGS} -lgfortran -lm -lkvm'"		\
>>  		>> ${WRKSRC}/setup.cfg
>> -	${ECHO_CMD} "OTHERLIB='-Xlinker -export-dynamic -lutil ${PTHREAD_LIBS} -lz'"	\
>> +	${ECHO_CMD} "OTHERLIB='-Xlinker -export-dynamic -lutil -lpthread -lz'"	\
> 
> I agree with you when you remove lines or patches such as
> 
> s/-lpthread/${PTHREAD_LIBS}/
> 
> but I disagree with your changes here: it's better to add
> ${PTHREAD_LIBS} than -lpthread.
> 

The blanket task is to remove ${PTHREAD_LIBS}.  We are going to remove
it from ports entirely.  And it only has one possible value (defined in
bsd.port.mk, so it's safe to replace with either -pthread or -lpthread
(the latter is preferred now).

John