svn commit: r381955 - head/graphics/gdal

[Bryan Drewery]

On 3/23/2015 10:06 AM, John Marino wrote:
> On 3/23/2015 16:03, John Marino wrote:
>> On 3/23/2015 15:58, Bryan Drewery wrote:
>>> On 3/23/2015 9:29 AM, John Marino wrote:
>>>> On 3/23/2015 15:24, Bryan Drewery wrote:
>>>>> -lpthread? Why not -lthr since -lpthread is actually an alias to that?
>>>>>
>>>>
>>>> There is no libthr.so on DragonFly.  That would break the port.
>>>>
>>>
>>> I do understand that and do not want to break DragonFly. However, I see
>>> it as the same argument as converting -pthread to -lpthread. It's more
>>> of an example.
>>
>>
>> We aren't adding the conversion of -pthread to -pthread; we are talking
>> about removing the conversion of -lpthread to -pthread.
>>
>> more specifically: we are talking about removing REINPLACE_CMD that
>> replaces -lpthread, removing patches that replace -pthread, and removing
>> the use of PTHREAD_LIBS.
>>
> 
> repeated with critical typo's fixed:
> We aren't adding the conversion of -pthread to -lpthread; we are talking
> about removing the conversion of -lpthread to -pthread.
> 
> more specifically: we are talking about removing REINPLACE_CMD that
> replaces -lpthread, removing patches that replace -lpthread, and
> removing the use of PTHREAD_LIBS.
> 
> Sorry!
> 

Ok. I think I understand now.

-	@${REINPLACE_CMD} -e 's|-lpthread|-pthread|g' ${WRKSRC}/configure

You want to just cleanup the needless replacements. The commit in
question was -2 lines +1 line. So it is an improvement.

I agree then with your plan as long as it is just cleaning up unneeded seds.

-- 
Regards,
Bryan Drewery

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20150323/4595ef91/attachment.sig>