svn commit: r380211 - head/security/libgpg-error

[John Marino]

On 3/1/2015 18:29, Antoine Brodin wrote:
> On Sun, Mar 1, 2015 at 4:59 PM, John Marino <freebsd.contact at marino.st> wrote:
>> On 3/1/2015 17:56, Antoine Brodin wrote:
>>> On Sun, Mar 1, 2015 at 4:52 PM, John Marino <marino at freebsd.org> wrote:
>>>> Author: marino
>>>> Date: Sun Mar  1 16:52:43 2015
>>>> New Revision: 380211
>>>> URL: https://svnweb.freebsd.org/changeset/ports/380211
>>>> QAT: https://qat.redports.org/buildarchive/r380211/
>>>>
>>>> Log:
>>>>   security/libgpg-error: Switch cpp to support gcc-5
>>>>
>>>>   This port relies on CPP behavior that changes on GCC 5.  To ensure
>>>>   libgpg-error keeps building on the newest GCC, add a build dependency
>>>>   on tradcpp and use it instead.
>>>>
>>>>   PR:           197562
>>>>   Submitted by: marino
>>>>   Approved by:  maintainer (novel)
>>>
>>> Hi,
>>>
>>> This breaks the port on freebsd head,  please revert.
>>>
>>> Cheers,
>>>
>>> Antoine
>>>
>>
>> Can you please provide link to the log?  I just poudriere tested this on
>> FreeBSD 10, so I'd like to know what's going on with FreeBSD 11.
>>
>> Also, technically FreeBSD 11 isn't supported yet.  I would rather we fix
>> than revert.  Can you help with that?
>>
> 
> Here is the log:
> 
> http://gohan2.ysv.freebsd.org/data/head-amd64-default/2015-03-01_17h06m04s/logs/errors/libgpg-error-1.17.log
> 
> The support for freebsd head is best effort,  but it's not acceptable
> to skip 2037 ports due to libgpg-error on it.
> Also,  head will become 11.0 and some parts of head are already merged
> in what will become 10.2
> 

Yes, I know about 2037 failures, I've experienced it firsthand.
I'm okay with reverting this *temporarily* but this is a regression on
FreeBSD 11.  We need to open a PR on this, tradcpp has to work.

Sound fair?
I'll revert the commit, and I'll open a PR against tradcpp and we make a
concerted effort to fix the regression?

John