svn commit: r390555 - head/comms/gnuradio

[Dmitry Marakasov]

* John Marino (freebsd.contact at marino.st) wrote:

> > Author: amdmi3
> > Date: Thu Jun 25 10:46:42 2015
> > New Revision: 390555
> > URL: https://svnweb.freebsd.org/changeset/ports/390555
> > 
> > Log:
> >   - Mark BROKEN on 9.x:
> >   
> >   /wrkdirs/usr/ports/comms/gnuradio/work/gnuradio-3.7.4/volk/kernels/volk/volk_8u_x4_conv_k7_r2_8u.h:191: error: incompatible type for argument 1 of '__builtin_ia32_psrlqi128'
> >   head/comms/gnuradio/Makefile
> > 
> > Modified: head/comms/gnuradio/Makefile
> > ==============================================================================
> > --- head/comms/gnuradio/Makefile	Thu Jun 25 10:40:00 2015	(r390554)
> > +++ head/comms/gnuradio/Makefile	Thu Jun 25 10:46:42 2015	(r390555)
> > @@ -35,6 +35,8 @@ LIB_DEPENDS=	libcppunit.so:${PORTSDIR}/d
> >  		libgsl.so:${PORTSDIR}/math/gsl
> >  RUN_DEPENDS:=	${BUILD_DEPENDS}
> >  
> > +BROKEN_FreeBSD_9=	does not build on FreeBSD 9.x
> > +
> 
> The "reason" is a bit redundant.
> code: > IGNORE=         is marked as broken on ${OPSYS} ${OSREL}:
> ${BROKEN_${OPSYS}_${OSREL:R}}
> 
> means fail reason string will be:
> 
> "is marked as broken FreeBSD 9.3: does not build on FreeBSD 9.x"
> 
> something like:
> BROKEN_FreeBSD_9=incompatible type for argument 1 of
> '__builtin_ia32_psrlqi128'
> 
> might be more descriptive?
> 
> This is just food for thought.  I always find the "broken on 9.x"
> messages not to add anything new.

Hm, I wasn't aware there were specialized message. I don't find pasting
compiler errors useful here, as this message is intended for end-users
and may be confusing to them. I guess I'll go with just 'does not build'
then.

-- 
Dmitry Marakasov   .   55B5 0596 FF1E 8D84 5F56  9510 D35A 80DD F9D2 F77D
amdmi3 at amdmi3.ru  ..:  jabber: amdmi3 at jabber.ru      http://amdmi3.ru