svn commit: r389121 - head/archivers/py-lz4

[Jung-uk Kim]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On 06/10/2015 23:12, Kubilay Kocak wrote:
> On 11/06/2015 4:14 AM, Jung-uk Kim wrote:
>> Author: jkim Date: Wed Jun 10 18:14:28 2015 New Revision: 389121 
>> URL: https://svnweb.freebsd.org/changeset/ports/389121
>> 
>> Log: Fix build dependency.
>> 
>> Modified: head/archivers/py-lz4/Makefile
>> 
>> Modified: head/archivers/py-lz4/Makefile 
>> ==============================================================================
>>
>> 
- --- head/archivers/py-lz4/Makefile	Wed Jun 10 18:12:35 2015	(r389120)
>> +++ head/archivers/py-lz4/Makefile	Wed Jun 10 18:14:28 2015
>> (r389121) @@ -11,6 +11,8 @@ COMMENT=	Python binding for the LZ4
>> comp
>> 
>> LICENSE=	BSD3CLAUSE
>> 
>> +BUILD_DEPENDS=
>> ${PYTHON_SITELIBDIR}/nose/__init__.py:${PORTSDIR}/devel/py-nose 
>> + USE_PYTHON=	autoplist distutils USES=		python
>> 
>> 
> 
> It's *very* likely setup_requires in setup.py adding a build
> dependency on nose [1] is a typo, and supposed to be tests_require
> 
> I would recommend patching setup.py to say:
> 
> setup_requires=["nose>=1.0"],

Done (r389157).

https://svnweb.freebsd.org/changeset/ports/389157

> And submitting the patch upstream in a PR.
> 
> [1] https://github.com/steeve/python-lz4/blob/master/setup.py#L34

There was one already and I just added a comment.

https://github.com/steeve/python-lz4/pull/35#issuecomment-110997473

Thanks!

Jung-uk Kim
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJVeSfrAAoJEHyflib82/FGZJUH/jz0QdXeEeBHDZMvhprUzREM
2x65DYsl4Ql4JQfwa7WSeDseucD2ohhi8R1HP7ttgXtusU8qLdqiUdzRP7Qzse16
qKqtF1HP851kKmoSVRdFB8+hvsw5eHgIkpZfDOlkRrVQGsbz/Tn0gM7zUR/7DBZs
RtBp/XPL7w8AKM6+8Q0VKIRGxsP+6JSwMTNtzyrehaJ4eFbFva8ejc+WF8TCfTMJ
3rGIMpA8Hoc2Iq5oFtj5r8Bcm513YBnkwqAbikui5JyOlVy7xCR5D4mXQu7i2EId
zFNJydj44w7d62vicFwOmgglY8rywDMuYW+k1IRwTCnNLexNCxVrLxjJ7Mc1DUA=
=4HCL
-----END PGP SIGNATURE-----