svn commit: r377022 - in head/benchmarks: . dhrystone dhrystone/files

[Alexey Dokuchaev]

On Wed, Jan 14, 2015 at 03:49:56PM +0000, Rodrigo Osorio wrote:
> New Revision: 377022
> URL: https://svnweb.freebsd.org/changeset/ports/377022
> QAT: https://qat.redports.org/buildarchive/r377022/
> 
> Log:
>   New port benchmarks/dhrystone : a computing benchmark for integer operations
>   [...]
> +MASTER_SITES=	${MASTER_SITE_NETLIB}
> +MASTER_SITE_SUBDIR=benchmark

Easier way: MASTER_SITES=NETLIB/benchmark (was recently mentioned on svn-*
lists, btw).

> +EXTRACT_CMD=	${MKDIR} ${WRKSRC};cd ${WRKSRC} && ${SH}

Cryptic line...  I would suggest an explanatory comment to accompany it.
We also usually wrap ";" when used as command separator with spaces.

> +.if ${PORT_OPTIONS:MDOCS}
> +PORTDOCS=	RATIONALE submit.frm README_C VARIATIONS
> +.endif

Bogus enclosure of PORTDOCS with .if/.endif.

> +do-build:
> +	cd ${WRKSRC} && ${CC} ${CFLAGS} -c dhry_1.c && \
> +		${CC} ${CFLAGS} -c dhry_2.c && \
> +		${CC} -o dhry *.o

It would be better to provide simple `files/Makefile' instead of handcrafted
do-build recipe.

> +.for f in ${PORTDOCS}
> +	${INSTALL_DATA} ${WRKSRC}/${f} ${STAGEDIR}${DOCSDIR}
> +.endfor

Better way:

	${INSTALL_DATA} ${PORTDOCS:S,^,${WRKSRC}/,} ${STAGEDIR}${DOCSDIR}

> +++ head/benchmarks/dhrystone/pkg-descr	Wed Jan 14 15:49:55 2015	(r377022)
> @@ -0,0 +1,12 @@
> +Dhrystone benchmark
> +

First two lines are bogus (redundant).

> +reported in DMIPS/Mhz. For more information, see 

I don't know a unit of "Mhz".  Perhaps it should read MHz instead?  Also,
bogus space at EOL here.

> +http://en.wikipedia.org/wiki/Dhrystone

Missing EOL full stop (period).

./danfe