svn commit: r379512 - in head/math/openblas: . files

[Gerald Pfeifer]

On Saturday 2015-02-21 13:40, Thomas Zander wrote:
> Log:
>   Add support for clang
>   
>   PR:		197385
>   Submitted by:	phd_kimberlite at yahoo.co.jp (maintainer)

> -USE_GCC=	yes

So far, so good.

> -	-e 's+%%_GCC_RUNTIME%%+${_GCC_RUNTIME}+' \
> +	-e 's+%%_GCC_VER%%+${_GCC_VER}+' \

This looks scary.  Why do you replace one variable starting with
an underscore by another variable starting with an underscore when
in Unix-land this convention means "internal use; not to be used
by regular users"?

> Modified: head/math/openblas/files/patch-Makefile.system
> ==============================================================================
> -+FCOMMON_OPT	+= -Wl,-rpath=%%_GCC_RUNTIME%%
> ++FCOMMON_OPT	+= -Wl,-rpath=%%LOCALBASE%%/lib/gcc%%_GCC_VER%%

And here it becomes really worrisome.  Instead of the internal
variable that at least had the full path set in a transparent
manner, now you construct this manually?  Totally relying on
implementation details that can (and likely _will_) change?

And without USE_GCC set, _GCC_VER is not going to set either,
is it?

I'm afraid something is broken here.  Can you please address it?

Gerald