svn commit: r379605 - in head/security/p5-Crypt-OpenSSL-X509: . files

[John Marino]

Author: marino
Date: Sun Feb 22 14:09:12 2015
New Revision: 379605
URL: https://svnweb.freebsd.org/changeset/ports/379605
QAT: https://qat.redports.org/buildarchive/r379605/

Log:
  security/p5-Crypt-OpenSSL-X509: Fix [-Werror=logical-not-parentheses]
  
  This bug was first discovered by Fedora 22 team building with gcc5 and
  they reported it upstream:
  
     https://github.com/dsully/perl-crypt-openssl-x509/issues/39
  
  I believe this patch is equivalent but a bit nicer than the fix suggested
  there.  The problem is "not (c < 0)" is desired but "(not c) < 0)" is
  what the condition evaluates to.  The joy of C.
  
  Approved by:	Just fix it

Added:
  head/security/p5-Crypt-OpenSSL-X509/files/
  head/security/p5-Crypt-OpenSSL-X509/files/patch-X509.xs   (contents, props changed)
Modified:
  head/security/p5-Crypt-OpenSSL-X509/Makefile

Modified: head/security/p5-Crypt-OpenSSL-X509/Makefile
==============================================================================
--- head/security/p5-Crypt-OpenSSL-X509/Makefile	Sun Feb 22 13:54:34 2015	(r379604)
+++ head/security/p5-Crypt-OpenSSL-X509/Makefile	Sun Feb 22 14:09:12 2015	(r379605)
@@ -3,7 +3,7 @@
 
 PORTNAME=	Crypt-OpenSSL-X509
 PORTVERSION=	1.8.04
-PORTREVISION=	2
+PORTREVISION=	3
 CATEGORIES=	security perl5
 MASTER_SITES=	CPAN
 PKGNAMEPREFIX=	p5-

Added: head/security/p5-Crypt-OpenSSL-X509/files/patch-X509.xs
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/security/p5-Crypt-OpenSSL-X509/files/patch-X509.xs	Sun Feb 22 14:09:12 2015	(r379605)
@@ -0,0 +1,20 @@
+--- X509.xs.orig	2013-12-01 17:14:25 UTC
++++ X509.xs
+@@ -181,7 +181,7 @@ static HV* hv_exts(X509* x509, int no_na
+   sv_2mortal((SV*)RETVAL);
+   c = X509_get_ext_count(x509);
+ 
+-  if ( ! c > 0 ) {
++  if ( c <= 0 ) {
+     croak("No extensions found\n");
+   }
+ 
+@@ -860,7 +860,7 @@ extension(x509, i)
+ 
+   c = X509_get_ext_count(x509);
+ 
+-  if (!c > 0) {
++  if (c <= 0) {
+     croak("No extensions found\n");
+   } else if (i >= c || i < 0) {
+     croak("Requested extension index out of range\n");