svn commit: r395409 - head/astro/geographiclib

[John Marino]

On 8/27/2015 12:59 PM, Dmitry Marakasov wrote:
> * Alexey Dokuchaev (danfe at FreeBSD.org) wrote:
> 
>>> New Revision: 395409
>>> URL: https://svnweb.freebsd.org/changeset/ports/395409
>>>
>>> [...]
>>>  GRAVITY_NAMES:=		egm84 egm96 egm2008 wgs84 grs80
>>> -MAGNETIC_NAMES:=	wmm2010 wmm2015 igrf11 igrf12 emm2010
>>> +MAGNETIC_NAMES:=	wmm2010 wmm2015 igrf11 igrf12 emm2010 emm2015
>>
>> Why := (assignment with immediate expansion) is used here, esp. for constant
>> values?
> 
> Ask maintainer.
> 

I thought it had been clearly established (by mat@ IIRC) that this kind
of response is not acceptable as a reason for ports mistakes.  The
committer is supposed to review the port he or she is committing and
catch errors.  The maintainers simply don't have the same level of
experience as committers do.

Probably answer:
Maintainer didn't know any better and the mistake has been missed every
time the port is maintained.

I'm fine with "I missed it" but not so much with blaming the maintainer
or assuming the maintainer did it intentionally for a good technical reason.

John