svn commit: r385072 - head/x11/lumina

[Jan Beich]

Kris Moore <kmoore at FreeBSD.org> writes:

> -PORTVERSION=	0.8.3.${GITVERSION}
> -PORTEPOCH=	1
> +PORTVERSION=	0.8.4
> +PORTREVISION=	1

PORTEPOCH cannot be removed.

$ portlint -C
FATAL: Makefile: lumina-0.8.4_1 < lumina-0.8.3.1427733141,1. Choose another PORTVERSION or bump PORTEPOCH.

> +USE_GITHUB=     yes
> +GH_ACCOUNT=     pcbsd
> +GH_COMMIT=      01bfb64
> +GH_TAGNAME=     v0.8.4-Release-P1

GH_COMMIT is deprecated and GH_TAGNAME is often a superset of PORTVERSION.
Also, spaces instead of tabs.

$ portlint -C
FATAL: Makefile: [43]: use a tab (not space) after a variable name
FATAL: Makefile: [44]: use a tab (not space) after a variable name
FATAL: Makefile: [45]: use a tab (not space) after a variable name
FATAL: Makefile: [46]: use a tab (not space) after a variable name

Index: x11/lumina/Makefile
===================================================================
--- x11/lumina/Makefile	(revision 385072)
+++ x11/lumina/Makefile	(working copy)
@@ -3,7 +3,9 @@
 
 PORTNAME=	lumina
 PORTVERSION=	0.8.4
-PORTREVISION=	1
+DISTVERSIONPREFIX=v
+DISTVERSIONSUFFIX=-Release-P1
+PORTEPOCH=	1
 CATEGORIES=	x11
 
 MAINTAINER=	kmoore at FreeBSD.org
@@ -40,10 +42,8 @@ USE_LDCONFIG=	yes
 USE_QT5=	core gui network svg linguist multimedia imageformats \
 		buildtools x11extras
 USES=		qmake tar:bzip2
-USE_GITHUB=     yes
-GH_ACCOUNT=     pcbsd
-GH_COMMIT=      01bfb64
-GH_TAGNAME=     v0.8.4-Release-P1
+USE_GITHUB=	yes
+GH_ACCOUNT=	pcbsd
 
 QMAKE_ARGS=	CONFIG+="configure"
 
Index: x11/lumina/distinfo
===================================================================
--- x11/lumina/distinfo	(revision 385072)
+++ x11/lumina/distinfo	(working copy)
@@ -1,2 +1,2 @@
-SHA256 (lumina-0.8.4.tar.bz2) = 311114964e900132a09e9acac46958da09d7ffb12a3e1d7653147b8952f658f0
-SIZE (lumina-0.8.4.tar.bz2) = 23261871
+SHA256 (pcbsd-lumina-v0.8.4-Release-P1_GH0.tar.bz2) = 5d54f60a534ea8d92259a6f57074173d9721492b7148a5fa5bcf8894beeffaf6
+SIZE (pcbsd-lumina-v0.8.4-Release-P1_GH0.tar.bz2) = 23261876
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 602 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20150501/27c560ab/attachment.sig>