svn commit: r384872 - in head/security: . passivedns passivedns/files

[Bryan Drewery]

On 4/28/2015 2:30 PM, Jan Beich wrote:
> Bryan Drewery <bdrewery at FreeBSD.org> writes:
> 
>> On 4/27/2015 3:33 PM, Lars Engels wrote:
>>
>>> +DISTVERSION=	${GH_TAG}
>> [...]
>>> +GH_TAG=		a6c7e26
>>
>> Actually this is not valid either. As soon as a new commit is done the
>> port may "go backwards".
> 
>> Commit hashses are not valid versions. Dates are.
> 
> git describe --tags output is no worse than appending svn revision to
> the nearest tag. DISTFILES was already partially correct.
> 
>   $ pkg version -t 1.1.3 1.1.3-60
>   <
> 
>> A PORTEPOCH bump will be needed as well after fixing this.
> 
> Not really. bsd.port.mk assumes any letter as a pre-release suffix.
> 
>   # PORTVERSION=a6c7e26
>   $ pkg version -t a6c7e26 0
>   <
> 
>   # DISTVERSION=a6c7e26
>   $ pkg version -t a6.c7.e26 0
>   <

No. The next hash could start with 'f' and the one after 'a'. Git hashes
are not monotonically increasing.


-- 
Regards,
Bryan Drewery

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20150429/0e5f1022/attachment.sig>