svn commit: r384872 - in head/security: . passivedns passivedns/files

[Jan Beich]

Bryan Drewery <bdrewery at FreeBSD.org> writes:

> On 4/27/2015 3:33 PM, Lars Engels wrote:
>
>> +DISTVERSION=	${GH_TAG}
> [...]
>> +GH_TAG=		a6c7e26
>
> Actually this is not valid either. As soon as a new commit is done the
> port may "go backwards".

> Commit hashses are not valid versions. Dates are.

git describe --tags output is no worse than appending svn revision to
the nearest tag. DISTFILES was already partially correct.

  $ pkg version -t 1.1.3 1.1.3-60
  <

> A PORTEPOCH bump will be needed as well after fixing this.

Not really. bsd.port.mk assumes any letter as a pre-release suffix.

  # PORTVERSION=a6c7e26
  $ pkg version -t a6c7e26 0
  <

  # DISTVERSION=a6c7e26
  $ pkg version -t a6.c7.e26 0
  <

>
> For example:
>
> PORTVERSION= 20150428

Please, don't advise unprefixed dates. If one later wants to go back to
a tag it'd require PORTEPOCH bump.

  $ pkg version -t 20150428 1.1.4
  >

  # PORTEPOCH=1
  $ pkg version -t 20150428 1.1.4,1
  <

Not to mention dates should correspond to the latest commit date, not an
arbitrary packaging date. For a6c7e26 it'd be 20150115 (UTC).

https://github.com/gamelinux/passivedns/commit/a6c7e26

> PORTEPOCH=   1
> GH_TAGNAME=  a6c7e26
>
> On updates just update the date and GH_TAGNAME.

Index: security/passivedns/Makefile
===================================================================
--- security/passivedns/Makefile	(revision 384934)
+++ security/passivedns/Makefile	(working copy)
@@ -1,9 +1,8 @@
 # $FreeBSD$
 
 PORTNAME=	passivedns
-DISTVERSION=	${GH_TAG}
+DISTVERSION=	1.1.3-60
 CATEGORIES=	security
-DISTFILES=	gamelinux-passivedns-1.1.3-60-ga6c7e26.tar.gz
 
 MAINTAINER=	shadowbq at gmail.com
 COMMENT=	Network sniffer that logs DNS replies for use in passive DNS setups
@@ -14,11 +13,8 @@ LIB_DEPENDS=	libldns.so:${PORTSDIR}/dns/ldns
 
 USE_GITHUB=	yes
 GH_ACCOUNT=	gamelinux
-GH_PROJECT=	passivedns
-GH_TAG=		a6c7e26
+GH_TAGNAME=	a6c7e26
 
-WRKSRC=		${WRKDIR}/gamelinux-${PORTNAME}-${GH_TAG}
-
 SUB_FILES=	pkg-message
 
 USES=		autoreconf gmake libtool
Index: security/passivedns/distinfo
===================================================================
--- security/passivedns/distinfo	(revision 384934)
+++ security/passivedns/distinfo	(working copy)
@@ -1,2 +1,2 @@
-SHA256 (gamelinux-passivedns-1.1.3-60-ga6c7e26.tar.gz) = efaff55f683309a2cdc42a366ec9f7669cf7989939b7928517fc60f2f258ce51
-SIZE (gamelinux-passivedns-1.1.3-60-ga6c7e26.tar.gz) = 51312
+SHA256 (gamelinux-passivedns-1.1.3-60-a6c7e26_GH0.tar.gz) = efaff55f683309a2cdc42a366ec9f7669cf7989939b7928517fc60f2f258ce51
+SIZE (gamelinux-passivedns-1.1.3-60-a6c7e26_GH0.tar.gz) = 51312
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 602 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20150428/91d0abc3/attachment.sig>