svn commit: r384682 - in head/security/keychain: . files

[Emanuel Haupt]

Emanuel Haupt <ehaupt at FreeBSD.org> wrote:
> Renato Botelho <garga at FreeBSD.org> wrote:
> > Author: garga
> > Date: Fri Apr 24 20:09:57 2015
> > New Revision: 384682
> > URL: https://svnweb.freebsd.org/changeset/ports/384682
> > 
> > Log:
> >   Update to 2.8.0
> >   
> >   PR:		199300 (based on)
> >   Submitted by:	adamw@
> 
> After the update I get:
> 
> $ keychain 
> /usr/local/bin/keychain: shopt: not found
> /usr/local/bin/keychain: 848: Syntax error: "(" unexpected (expecting
> ")")
> 

Looking at it a bit closer shows that the new version sets:

shopt -s extglob

but uses:

#!/bin/sh

This is probably no problem on most Linuxes that simply link /bin/sh
to /bin/bash but it won't work on FreeBSD.

The way I see it keychain needs to either start using

#!/usr/local/bin/bash

as shebang or the expressions that require extglob need to be
made FreeBSD /bin/sh compatible. The first one is IMHO better
for future maintainability.

Emanuel