svn commit: r384239 - in head/games/gtkradiant: . files

[Alexey Dokuchaev]

On Wed, Apr 22, 2015 at 01:30:06PM +0300, Dmitry Marakasov wrote:
> * Alexey Dokuchaev (danfe at FreeBSD.org) wrote:
> > New Revision: 384239
> > URL: https://svnweb.freebsd.org/changeset/ports/384239
> > 
> > Log:
> > [...]
> >   - Clang insists that reference cannot be bound to dereferenced null
> >     pointer in well-defined C++ code (that is correct) and evaluates
> >     comparisons like &foo == 0 to false, which breaks GtkRadiant; "fix"
> >     this with a dirty hack by casting those "bad" references to a
> >     local volatile int variable
> 
> gtk- and netradiant are now broken on amd64.

Oops, of course, it should'be been intptr_t.  I currently do not have any
64-bit hardware to do the tests, hence I've missed it. :(

> While here, don't miss [PR 199562]

I won't miss it, but it might take couple of days to review the patch (even
though you seemingly already did most the of work, thanks!).

./danfe