svn commit: r384031 - in head/net/libsrtp: . files

[Tijl Coosemans]

On Tue, 14 Apr 2015 22:24:44 +0000 (UTC) Mikhail Teterin <mi at FreeBSD.org> wrote:
> Author: mi
> Date: Tue Apr 14 22:24:44 2015
> New Revision: 384031
> URL: https://svnweb.freebsd.org/changeset/ports/384031
> 
> Log:
>   Only use -fPIC, when compiling shared objects, not static ones.

You should be careful with changes like this.  In my opinion this should
be discussed and decided upstream and not in a port.  I'm working on an
update of mediastreamer (and linphone) and it wants to link libsrtp.a
into a shared library under some conditions.  These conditions don't
apply to us, but it does show that there might be code out there that
expects libsrtp.a to be compiled with -fPIC.

There are a number of ports that blindly add -fPIC to CFLAGS and I'm all
for removing that or adding comments explaining why it's necessary, but
when upstream compiles static libraries with -fPIC I don't think we
should change that.