svn commit: r383843 - head/games/megaglest

[John Marino]

On 4/12/2015 15:00, Jan Beich wrote:
> John Marino <marino at FreeBSD.org> writes:
> 
>>   Megaglest cannot be built under c++11 standard from the latest clang.
>>   It catches a narrowing error.  The real solution is to fix the c++
>>   code (it wasn't the only problem, but the first to trigger an error over
>>   a warning).  The c++11 standard is required for wx, so it can't be
>>   unspecified.  It turns out that gcc48 will not catch the error that clang
>>   does so the temporary fix is to require gcc48 for all FreeBSD releases.
>>   This may work for gcc49 as well, but it's likely that gcc5 will also
>>   catch the bug and break.
> 
> CXXFLAGS += -Wno-c++11-narrowing ? GCC ignores unknown -Wno-foo.
> 
> Or maybe poke upstream if it has a fix:
> 
> #v+
> Clang fix for tdefl_write_image_to_png_file_in_memory() from toffaletti
> 
> --- source/shared_lib/sources/miniz/miniz.c	(revision 56)
> +++ source/shared_lib/sources/miniz/miniz.c	(revision 57)


IIUC - you're saying 1) what I did builds but doesn't work and 2) you've
got a patch that will let it build on clang.

If I got that right, just go ahead and commit it.  Are you flying solo
or with implicit permission these days?

Thanks!

John