svn commit: r383191 - head/Mk

[Bryan Drewery]

On 4/9/2015 11:49 AM, Dmitry Marakasov wrote:
> * Bryan Drewery (bdrewery at FreeBSD.org) wrote:
> 
>>>> *That* made sense. Frankly I think all dev warnings should be disabled
>>>> in that case though. Setting up ports like this may work but it is not a
>>>> good way to test a port before committing or submitting it. Many ports
>>>> and their framework files reference "CURDIR/../..". In r327743 I
>>>> modified www/linux-seamonkey to use PORTSDIR here and I believe I broke
>>>> the workflow for the maintainers testing. The ports tree really needs to
>>>> be tested as a whole. This is why portshaker exists, so you can bring in
>>>> your partial tree into a full tree. Unionfs in theory is for this too.
>>>
>>> Bryan, I'm on Dmitry's side here.  Building some "foo" port from outside
>>> /usr/ports (or a properly checked out tree) is very handy feature, and it
>>> had worked for many years; and while perhaps never officially advertised,
>>> silently breaking it is a huge POLA violation for power users.  I would
>>> really appreciate if we can have this behavior back.
>>
>> I am in favor of fixing it. I just think all the tests should be
>> disabled. It won't make sense to have some tests enabled and some not.
>> It's no good if the port passes in your out-of-tree build for 1/2 the
>> tests and then you just straight commit and find that it fails all of
>> the other tests.
> 
> I don't see the point. Why disable all checks while they can detect
> problems early (while the port is still out-of-tree), instead of
> making developer experience inconsistent behavior without explanation?
> In either case, we need something like
> 
> WARNING+="the port doesn't reside in the ports tree directory structure, not all sanity checks could be performed"
> 
> but I'd really prefer only tests which are ctually affected by this to be
> disabled.
> 

This is what my proposed patch does!

-- 
Regards,
Bryan Drewery

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20150409/0fc81ecb/attachment.sig>