svn commit: r383191 - head/Mk

[Dmitry Marakasov]

* Bryan Drewery (bdrewery at FreeBSD.org) wrote:

> >>   Re-enable and rework check added in r370464 to validate the first CATEGORY
> >>   is set properly.  The problem causing the revert in r370475 was fixed in
> >>   r383190.
> >>   
> >>   With hat:	portmgr
> > 
> > This breaks countless usecases when port is build which does not belong
> > to the ports tree.
> 
> Please name even 1 case.

I have a lot of WIP ports in flat directory. Tons of custom port
repositories on github with flat structure.

> Building a port with the wrong first CATEGORY results in a broken
> package as the origin is wrong.

I'm not talking about wrong categories, I'm talking about ports outside
of the ports tree. These should build perfectly fine.

> > Afaik, we have that information in ports - based on
> > that PORTSDIR is chosen. The same mechanism should be used here to
> > conditionally enable the check.
> 
> That made no sense.

Explain.

-- 
Dmitry Marakasov   .   55B5 0596 FF1E 8D84 5F56  9510 D35A 80DD F9D2 F77D
amdmi3 at amdmi3.ru  ..:  jabber: amdmi3 at jabber.ru      http://amdmi3.ru