svn commit: r383538 - head/databases/sqlitemanager

[Baptiste Daroussin]

On Tue, Apr 07, 2015 at 06:37:52PM -0500, Bryan Drewery wrote:
> On 4/7/2015 3:26 PM, John Marino wrote:
> > On 4/7/2015 22:14, Mikhail Teterin wrote:
> >> Author: mi
> >> Date: Tue Apr  7 20:14:55 2015
> >> New Revision: 383538
> >> URL: https://svnweb.freebsd.org/changeset/ports/383538
> >>
> [...]
> >>  do-install:
> >>  	${MKDIR} ${STAGEDIR}${WWWDIR}
> >> -	${CP} -R ${WRKSRC}/ ${STAGEDIR}${WWWDIR}
> >> +	${CP} -Rp ${WRKSRC}/ ${STAGEDIR}${WWWDIR}
> > 
> >         ^^^^^
> > 
> > Why use ${CP} over ${COPYTREE_SHARE} ?
> > There was just a big reminder not to install files with ${CP} last week
> > on this mail list ...
> > 
> > John
> > 
> 
> I don't see it. What's wrong with cp?
> 
> -- 
> Regards,
> Bryan Drewery
> 

COPYTREE_SHARE enforces the owner (now useless with pkg(8)) and the mode to be
the proper expected ones in packages
While CP is blindly copying

Best regards,
Bapt
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20150408/5b02f6f6/attachment.sig>