svn commit: r349288 - head/archivers/ocaml-bz2

[Antoine Brodin]

On Wed, Mar 26, 2014 at 11:17 PM, John Marino <freebsd.contact at marino.st> wrote:
> On 3/26/2014 21:18, Antoine Brodin wrote:
>> Author: antoine
>> Date: Wed Mar 26 20:18:38 2014
>> New Revision: 349288
>> URL: http://svnweb.freebsd.org/changeset/ports/349288
>> QAT: https://qat.redports.org/buildarchive/r349288/
>>
>> Log:
>>   Stage support
>>
>> Modified:
>>   head/archivers/ocaml-bz2/Makefile
>>
>> Modified: head/archivers/ocaml-bz2/Makefile
>> ==============================================================================
>> --- head/archivers/ocaml-bz2/Makefile Wed Mar 26 20:09:29 2014        (r349287)
>> +++ head/archivers/ocaml-bz2/Makefile Wed Mar 26 20:18:38 2014        (r349288)
>> @@ -12,10 +12,9 @@ DISTNAME=  caml${PORTNAME}-${PORTVERSION}
>>  MAINTAINER=  jaapb at kerguelen.org
>>  COMMENT=     OCaml library to manipulate bz2 files
>>
>> +DESTDIRNAME= DONTUSEIT
>>  GNU_CONFIGURE=       yes
>>  USES=                gmake
>> -NO_STAGE=    yes
>> -
>
> You left USE_OCAML_LDCONFIG=     yes.
> Won't this create an ldconf file that will get added to plist and will
> conflict potentially with the real ldconf?
>
> USE_OCAML_WASH is also set.  Is this knob actually desireable?  Why is
> it needed if it's competing with pkg to remove files?
>
> I'm not saying I'm right, I'm just trying to learn this.


Hi,

I modifed bsd.ocaml.mk so now USE_OCAML_LDCONFIG doesn't violate
stagedir anymore.

For USE_OCAML_WASH,  I have doubts on its usefulness, maybe it should
be garbage collected in all the tree.

Cheers,

Antoine