svn commit: r348328 - in head/devel/libkolab: . files

[Raphael Kubo da Costa]

Author: rakuco
Date: Sat Mar 15 14:36:20 2014
New Revision: 348328
URL: http://svnweb.freebsd.org/changeset/ports/348328
QAT: https://qat.redports.org/buildarchive/r348328/

Log:
  Add a patch sent upstream to fix the build with clang 3.4.
  
  clang 3.4 is pickier with the flags it accepts, and refuses to work with the
  GCC-specific -fno-check-new.

Added:
  head/devel/libkolab/files/
  head/devel/libkolab/files/patch-CMakeLists.txt   (contents, props changed)
Modified:
  head/devel/libkolab/Makefile

Modified: head/devel/libkolab/Makefile
==============================================================================
--- head/devel/libkolab/Makefile	Sat Mar 15 14:31:48 2014	(r348327)
+++ head/devel/libkolab/Makefile	Sat Mar 15 14:36:20 2014	(r348328)
@@ -2,6 +2,7 @@
 
 PORTNAME=	libkolab
 PORTVERSION=	0.5.0
+PORTREVISION=	1
 CATEGORIES=	devel kde
 MASTER_SITES=	http://mirror.kolabsys.com/pub/releases/
 

Added: head/devel/libkolab/files/patch-CMakeLists.txt
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/devel/libkolab/files/patch-CMakeLists.txt	Sat Mar 15 14:36:20 2014	(r348328)
@@ -0,0 +1,20 @@
+Remove -fno-check-new from CXX_FLAGS.
+
+The same reasoning given when this flag was removed from Akonadi also
+applies here: this a GCC-specific flag that makes the Clang build fail with
+Clang 3.4 (which started failing when unsupported flags are passed to it),
+and the overhead of non-null checks should be minimal.
+
+Sent upstream: http://lists.kolab.org/pipermail/devel/2014-March/014987.html
+--- CMakeLists.txt
++++ CMakeLists.txt
+@@ -82,7 +82,7 @@ if("${KdepimLibs_VERSION}" VERSION_GREATER "4.8.40" OR USE_LIBCALENDARING)
+     add_definitions(-DKDEPIMLIBS_VERSION_DEVEL)
+ endif()
+ 
+-set( CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wnon-virtual-dtor -Wno-long-long -ansi -Wundef -Wcast-align -Wchar-subscripts -Wall -W -Wpointer-arith -Wformat-security -fno-exceptions -DQT_NO_EXCEPTIONS -fno-check-new -fno-common -Woverloaded-virtual -fno-threadsafe-statics -fvisibility=hidden -Werror=return-type -fvisibility-inlines-hidden -fexceptions -UQT_NO_EXCEPTIONS -fPIC -g" )
++set( CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wnon-virtual-dtor -Wno-long-long -ansi -Wundef -Wcast-align -Wchar-subscripts -Wall -W -Wpointer-arith -Wformat-security -fno-exceptions -DQT_NO_EXCEPTIONS -fno-common -Woverloaded-virtual -fno-threadsafe-statics -fvisibility=hidden -Werror=return-type -fvisibility-inlines-hidden -fexceptions -UQT_NO_EXCEPTIONS -fPIC -g" )
+ # message("${CMAKE_CXX_FLAGS}")
+ set(CMAKE_CXX_FLAGS_RELEASE "${CMAKE_CXX_FLAGS_RELEASE} -DQT_NO_DEBUG")
+ 
+