svn commit: r363361 - in head/editors/fte: . files

Alexey Dokuchaev danfe at FreeBSD.org
Wed Jul 30 16:08:43 UTC 2014


On Wed, Jul 30, 2014 at 08:14:14AM +0000, Alexey Dokuchaev wrote:
> On Wed, Jul 30, 2014 at 10:08:05AM +0200, Mathieu Arnold wrote:
> > But, I think you're missing the point, who cares what the separator is ?
> > All it needs to do is work when I run make patch. Also, all one needs to
> > know is that to generate the patches, you run make makepatch.
> 
> Well, if you don't care, then I guess you won't mind if we change it to
> something more appealing to those who do care.

Given some thought over it, I propose the following changes to makepatch:

  - default to dash (minus, '-')
  - provide a command line option (-s?) or make(1) variable (PATH_SEPARATOR)
    to override it when needed
  - assert that forced value is not something insane ('__', '::', '../../',
    etc.) -- basically, match it over a prerefined list of acceptable values

I can cook up a patch unless John had beaten me on that already.

./danfe


More information about the svn-ports-all mailing list