make makepatch and per-file diffs [WAS: Re: svn commit: r363361 - in head/editors/fte: . files]

[Eygene Ryabinkin]

Wed, Jul 30, 2014 at 10:08:05AM +0200, Mathieu Arnold wrote:
> But, I think you're missing the point, who cares what the separator
> is ?  All it needs to do is work when I run make patch. Also, all
> one needs to know is that to generate the patches, you run make
> makepatch.

Pardon me, but this is a short-term or port's user point of view.

Port maintainers may (and should) also have some idea on what's the
patch is about and to have not just single patch file for a single
modified file, but have different hunks that are related to a single
change to be grouped together in one file.  That horribly eases the
maintainership and its transfer to other persons (especially the
latter).

Currently 'make makepatch' takes us even behind CVS era where you
had one diff for each commit and each file: it glues together all
(possibly unrelated) changes in a single file to a single diff.

Yes, there is an issue for patch ordering and 'make makepatch' tries
to solve precisely that problem putting everything to per-file diffs.
But it misses the whole point of having good quality patches inside
files/ and does only poor-man work.
-- 
Eygene Ryabinkin                                        ,,,^..^,,,
[ Life's unfair - but root password helps!           | codelabs.ru ]
[ 82FE 06BC D497 C0DE 49EC  4FF0 16AF 9EAE 8152 ECFB | freebsd.org ]
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 358 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20140730/f69d449c/attachment.sig>