svn commit: r363361 - in head/editors/fte: . files

[John Marino]

On 7/30/2014 09:37, Mathieu Arnold wrote:
> +--On 30 juillet 2014 09:29:03 +0200 John Marino
> <freebsd.contact at marino.st> wrote:
> | On 7/30/2014 09:25, Max Brazhnikov wrote:
> |> On Wed, 30 Jul 2014 07:04:13 +0000 Alexey Dokuchaev wrote:
> |>> On Tue, Jul 29, 2014 at 01:10:45PM -0400, Adam Weinberger wrote:
> |>>> I'm about to rename all patches that contain ::. Can we please stop
> |>>> producing patches with :: as a path separator, and use __ instead?
> |>> 
> |>> Can we also stop using double underscore as it makes patch names so ugly
> |>> and unreadable that I have to spend twice as much time working on ports
> |>> that uses this stupid convention?
> |> 
> |> It comes from the makepatch target.
> | 
> | Makepatch name convention is no good.  I was complaining about this (to
> | bapt) about the lack of a patch name convention and he said to propose
> | one.  I've been meaning to do just that, but it also means fixing tools
> | like this.
> 
> makepatch name convention is the convention, I find it pretty simple, and
> easy to remember, it does "s|/|__|" and that's all.  Whatever the
> convention, there's always someone who will not like it, but it doesn't
> really matter, it's a convention so that everyone knows how to name patch
> files the same way.

I disagree, there is no convention.  Whoever created makepatch attempted
to create a defacto convention that most people don't like (as evidence
that patches not created by makepatch don't use it but rather the more
conventional* single underscore.  I don't automatically recognize the
author of makepatch the authority.

* As seen in other repos such as pkgsrc

Take a vote. I'd bet the majority of people do not like "__" not just
"someone".