svn commit: r363195 - in head/devel: p5-Module-Build p5-Module-Build-Tiny

[Sunpoet Po-Chuan Hsieh]

On Tue, Jul 29, 2014 at 12:08 AM, Mathieu Arnold <mat at freebsd.org> wrote:

> Author: mat
> Date: Mon Jul 28 16:08:00 2014
> New Revision: 363195
> URL: http://svnweb.freebsd.org/changeset/ports/363195
> QAT: https://qat.redports.org/buildarchive/r363195/
>
> Log:
>   Reword the comment here so that updating the build depends version is not
>   forced here if it is not needed.
>
>   With hat:     perl@
>   Sponsored by: Absolight
>
> Modified:
>   head/devel/p5-Module-Build-Tiny/Makefile
>   head/devel/p5-Module-Build/Makefile
>
> Modified: head/devel/p5-Module-Build-Tiny/Makefile
>
> ==============================================================================
> --- head/devel/p5-Module-Build-Tiny/Makefile    Mon Jul 28 16:03:51 2014
>      (r363194)
> +++ head/devel/p5-Module-Build-Tiny/Makefile    Mon Jul 28 16:08:00 2014
>      (r363195)
> @@ -1,8 +1,9 @@
>  # Created by: Sunpoet Po-Chuan Hsieh <sunpoet at FreeBSD.org>
>  # $FreeBSD$
>  #
> -# Do not forget to update p5-Module-Build-Tiny version in Mk/Uses/
> perl5.mk
> -# while updating this port!
> +# If you have compelling evidence that some ports need at least this
> version of
> +# p5-Module-Build-Tiny to build, be sure to update the BUILD_DEPENDS
> version in
> +# Mk/Uses/perl5.mk.
>
>  PORTNAME=      Module-Build-Tiny
>  PORTVERSION=   0.037
>
> Modified: head/devel/p5-Module-Build/Makefile
>
> ==============================================================================
> --- head/devel/p5-Module-Build/Makefile Mon Jul 28 16:03:51 2014
>  (r363194)
> +++ head/devel/p5-Module-Build/Makefile Mon Jul 28 16:08:00 2014
>  (r363195)
> @@ -1,8 +1,9 @@
>  # Created by: Dmitry Sivachenko <demon at FreeBSD.org>
>  # $FreeBSD$
>  #
> -# Do not forget to update p5-Module-Build version in Mk/Uses/perl5.mk
> -# while updating this port!
> +# If you have compelling evidence that some ports need at least this
> version of
> +# p5-Module-Build to build, be sure to update the BUILD_DEPENDS version in
> +# Mk/Uses/perl5.mk.
>
>  PORTNAME=      Module-Build
>  PORTVERSION=   0.4206
>
>
Hi mat,

Thanks for your rewording. It's more clear now.

Let me explain why I added the original comment.
I think it's harmless to use latest version in most cases.

To my experience, (my) ports using Module::Build::Tiny usually require
up-to-date version.
Recent examples:
- devel/p5-MooseX-Types-DateTime-MoreCoercions 0.12 (Jul 21, 2014) requires
Module::Build::Tiny 0.036 (May 2, 2014).
- devel/p5-MooseX-Runnable 0.07 (Feb 18, 2014) requires Module::Build::Tiny
0.035 (Feb 17, 2014).
Therefore, I'l update Mk/Uses/perl5.mk along with
devel/p5-Module-Build-Tiny.
The comment here can be removed I guess. :)

I don't have Module::Build case in hand.

Regards,
sunpoet