svn commit: r362304 - head/x11-toolkits/pango

[Baptiste Daroussin]

On Sun, Jul 20, 2014 at 01:26:40PM +0200, John Marino wrote:
> On 7/20/2014 13:22, Tijl Coosemans wrote:
> > On Sun, 20 Jul 2014 08:15:16 +0000 (UTC) John Marino wrote:
> >> Author: marino
> >> Date: Sun Jul 20 08:15:16 2014
> >> New Revision: 362304
> >> URL: http://svnweb.freebsd.org/changeset/ports/362304
> >> QAT: https://qat.redports.org/buildarchive/r362304/
> >>
> >> Log:
> >>   x11-toolkits/pango: require explicit linking
> >>   
> >>   This new configure argument will list all required libraries in the
> >>   generated pkgconf files.  Before any library indirectly pulled in, such
> >>   as libm, was not listed.
> >>   
> >>   This fixes numerous regression in dports and it's more correct anyway.
> > 
> > No, this is wrong.  Each port should link to the libraries it needs on
> > its own.  No port should rely on other ports to pull in libraries for
> > them.
> 
> Then I guess we really don't need pkgconfig .pc files at all then?
> (This is the point of .pc files, it tells how to link.  libm is directly
> used by pango)
> 
> so no, it is not wrong.  The generated pc file was wrong, now it's not.
>  This is why the configuration argument exists.
> 
The good question is "does pango exposes parts of libm or not?" if yes then libm
should be listed in the libraries of pango.pc is not it should only appears in
the private field.

regards,
Bapt
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20140720/96f58c84/attachment.sig>