svn commit: r361631 - head/multimedia/vlc

[Adam Weinberger]

On 13 Jul, 2014, at 14:13, Tijl Coosemans <tijl at FreeBSD.org> wrote:

> On Sun, 13 Jul 2014 12:53:25 -0400 Adam Weinberger wrote:
>> On 13 Jul, 2014, at 12:49, Baptiste Daroussin <bapt at FreeBSD.org> wrote:
>>> On Sun, Jul 13, 2014 at 12:40:38PM -0400, Adam Weinberger wrote:
>>>> On 12 Jul, 2014, at 14:03, Juergen Lock <nox at FreeBSD.org> wrote:
>>>> 
>>>>> Modified: head/multimedia/vlc/Makefile
>>>>> ==============================================================================
>>>>> --- head/multimedia/vlc/Makefile	Sat Jul 12 17:58:06 2014	(r361630)
>>>>> +++ head/multimedia/vlc/Makefile	Sat Jul 12 18:03:24 2014	(r361631)
>>>>> @@ -198,6 +198,7 @@ MTP_CONFIGURE_ENABLE=	mtp
>>>>> 
>>>>> MUSEPACK_LIB_DEPENDS=	libmpcdec.so:${PORTSDIR}/audio/musepack
>>>>> MUSEPACK_CONFIGURE_ENABLE=	mpc
>>>>> +MUSEPACK_CONFIGURE_ENV=		LIBS_mpc="-L${LOCALBASE}/lib -lmpcdec”
>>>> 
>>>> You want MUSEPACK_CONFIGURE_ON here. ${opt}_CONFIGURE_ENV doesn’t exist.
>>>> 
>>>> bapt can tell you how many times I’ve made that mistake...
>>> 
>>> Well ${opt}_CONFIGURE_ENV does exists :) your mistake was another one I don't
>>> remember :)
>> 
>> Oh, crap! That’s right... it was _CONFIGURE_ARGS that I keep trying for. I
>> give _CONFIGURE_* a 10-foot berth now.
> 
> Now that we have *_OFF we could make CONFIGURE_ARGS the same
> as CONFIGURE_ENV by adding support for *_CONFIGURE_ARGS and
> *_CONFIGURE_ARGS_OFF (and maybe mark *_CONFIGURE_ON and
> *_CONFIGURE_OFF deprecated).

I’d certainly break things less often that way.

# Adam


-- 
Adam Weinberger
adamw at adamw.org
http://www.adamw.org