svn commit: r341406 - head/devel/bncsutil-ghost++

[Baptiste Daroussin]

On Mon, Jan 27, 2014 at 02:08:36PM +0000, Alexey Dokuchaev wrote:
> On Mon, Jan 27, 2014 at 01:37:57PM +0000, Baptiste Daroussin wrote:
> > New Revision: 341406
> > URL: http://svnweb.freebsd.org/changeset/ports/341406
> > QAT: https://qat.redports.org/buildarchive/r341406/
> > 
> > +MAKE_ARGS=	PREFIX=${STAGEDIR}${PREFIX}
> 
> It would be nice (per our previous discussion) to briefly summarize in the
> commit log why, in the particular case, such construct is safe, as generally
> is is not.
> 
> ./danfe

Right in that case I check that PREFIX is only used during the install phase (in
the upstream build process) I also checked that the install process wasn't going
to hardcode PREFIX somewhere.

I run stage-qa and verified if nothing yelled at me :)

With both checks I knew that it was safe to cheat on the prefix to install
directly on stagedir.

regards,
Bapt
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20140127/eacc8464/attachment.sig>