svn commit: r340026 - head/net-im/libpurple

[Pietro Cerutti]

On 2014-Jan-17, 11:47, Mathieu Arnold wrote:
> +--On 17 janvier 2014 10:33:09 +0000 Pietro Cerutti <gahr at FreeBSD.org>
> wrote:
> |  .if ${PORT_OPTIONS:MTCLTK}
> | -USE_TK=			yes
> | -CFLAGS+=		-I${LOCALBASE}/include/tk${TK_VER}
> | -I${LOCALBASE}/include/tcl${TCL_VER} -CONFIGURE_ARGS+=
> | 	--with-tclconfig=${LOCALBASE}/lib/tcl${TCL_VER} \ -
> | 	--with-tkconfig=${LOCALBASE}/lib/tk${TK_VER}
> | +USES+=			tk
> | +CFLAGS+=		-I${TK_INCLUDEDIR} -I${TCL_INCLUDEDIR}
> | +CONFIGURE_ARGS+=	--with-tclconfig=${TCL_LIBDIR} \
> | +			--with-tkconfig=${TK_LIBDIR}
> 
> Which is way better written as :
> 
> TCLTK_USES=             tk
> TCLTK_CFLAGS=		-I${TK_INCLUDEDIR} -I${TCL_INCLUDEDIR}
> TCLTK_CONFIGURE_ON=	--with-tclconfig=${TCL_LIBDIR} \
> 			--with-tkconfig=${TK_LIBDIR}

Nice framework. But given that I have to enclose stuff in
.if ${PORT_OPTIONS:MTCLTK} 
anyway because of PLIST_SUB and CONFIGURE_ARGS, what's the benefit?

-- 
Pietro Cerutti
The FreeBSD Project
gahr at FreeBSD.org

PGP Public Key:
http://gahr.ch/pgp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 964 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20140117/6054fd94/attachment.sig>