svn commit: r345889 - head/editors/vim

[Bryan Drewery]

On 2/24/2014 1:05 PM, Sunpoet Po-Chuan Hsieh wrote:
> On Tue, Feb 25, 2014 at 2:51 AM, Bryan Drewery <bdrewery at freebsd.org
> <mailto:bdrewery at freebsd.org>> wrote:
> 
>     On 2/24/2014 12:44 PM, Sunpoet Po-Chuan Hsieh wrote:
>     > Author: sunpoet
>     > Date: Mon Feb 24 18:44:16 2014
>     > New Revision: 345889
>     > URL: http://svnweb.freebsd.org/changeset/ports/345889
>     > QAT: https://qat.redports.org/buildarchive/r345889/
>     >
>     > Log:
>     >   - Fix lua support
>     >
>     >   PR:         ports/186917
>     >   Submitted by:       Kenji Rikitake <kenji at k2r.org
>     <mailto:kenji at k2r.org>>
>     >
>     > Modified:
>     >   head/editors/vim/Makefile
>     >
>     > Modified: head/editors/vim/Makefile
>     >
>     ==============================================================================
>     > --- head/editors/vim/Makefile Mon Feb 24 18:39:50 2014      
>      (r345888)
>     > +++ head/editors/vim/Makefile Mon Feb 24 18:44:16 2014      
>      (r345889)
>     > @@ -159,7 +159,7 @@ pre-configure:
>     >       @${REINPLACE_CMD} -e 's|/usr/local|${LOCALBASE}|g' \
>     >               -e
>     's|\$$gtk_config_prefix/bin/gtk-config|\$${GTK_CONFIG}|g' \
>     >               -e
>     's|\$$gtk_config_exec_prefix/bin/gtk-config|\$${GTK_CONFIG}|g' \
>     > -             -e 's|set dummy lua;|set dummy lua-${LUA_VER};|g'
>     ${WRKSRC}/src/auto/configure
>     > +             -e 's|set dummy lua;|set dummy ${LUA_CMD};|g'
>     ${WRKSRC}/src/auto/configure
>     >  .if ${PORT_OPTIONS:MXTERM_SAVE}
>     >       @${REINPLACE_CMD} -e '/FEAT_XTERM_SAVE/ s|.*|#define
>     FEAT_XTERM_SAVE|' ${WRKSRC}/src/feature.h
>     >  .endif
>     >
> 
>     Was this a build-time failure or runtime change? The PR suggests a
>     runtime issue. If runtime needs a PORTREVISION bump, regardless of
>     default options.
> 
> 
> I just made a PORTREVISION bump in r345888 which is 5 minutes before
> this commit.
> IIRC, does the 10-minute rule apply?

Technically yes it needs a bump. Someone may have built packages in
those 5 minutes. They may have email hooks on updates to their ports to
trigger builds. Maybe they build ports at :40 minute marker. Who knows.
I've frequently hit problems in packages because the revision was not
bumped. Without it you now have 2 different behaving 7.4*_1 packages.

I understand if you don't want to bump it now, just try to group runtime
changes better next time :)

-- 
Regards,
Bryan Drewery

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 553 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20140224/1dc77ccf/attachment.sig>