svn commit: r345514 - head/Mk/Uses

[Tijl Coosemans]

On Fri, 21 Feb 2014 20:30:04 +0100 Baptiste Daroussin wrote:
> On Fri, Feb 21, 2014 at 07:49:49PM +0100, Tijl Coosemans wrote:
>> On Fri, 21 Feb 2014 16:47:29 +0000 (UTC) Baptiste Daroussin wrote:
>>> Author: bapt
>>> Date: Fri Feb 21 16:47:29 2014
>>> New Revision: 345514
>>> URL: http://svnweb.freebsd.org/changeset/ports/345514
>>> QAT: https://qat.redports.org/buildarchive/r345514/
>>> 
>>> Log:
>>>   libtool 1.4.2a was defining the shared extension as shrext_cmds, rename it shared_ext
>>>   like in newer libtool so the rest of USES=iconv magic just works
>>> 
>>> Modified:
>>>   head/Mk/Uses/libtool.mk
>>> 
>>> Modified: head/Mk/Uses/libtool.mk
>>> ==============================================================================
>>> --- head/Mk/Uses/libtool.mk	Fri Feb 21 16:04:38 2014	(r345513)
>>> +++ head/Mk/Uses/libtool.mk	Fri Feb 21 16:47:29 2014	(r345514)
>>> @@ -22,7 +22,8 @@ patch-libtool:
>>>  		-e '/link_all_deplibs[0-9A-Z_]*=/s/=unknown/=no/'	\
>>>  		-e '/objformat=/s/echo aout/echo elf/'			\
>>>  		-e "/freebsd-elf\\*)/,/;;/ {				\
>>> -		    /deplibs_check_method=/s/=.*/=pass_all/; }"
>>> +		    /deplibs_check_method=/s/=.*/=pass_all/; }"		\
>>> +		-e "s/shrext_cmds/shared_ext/g"
>>>  
>>>  .if ! ${libtool_ARGS:Moldver}
>>>  	@${FIND} ${WRKDIR} \( -name configure -or -name ltconfig \)	\
>> 
>> Both shrext_cmds and shared_ext exist so I'm not sure it's safe to use
>> only one name.  shrext_cmds is defined by configure (normally just .so
>> for us) or by libtool when invoked with -shrext some_extension.  Then
>> later libtool defines shared_ext using 'eval shared_ext=\"$shrext_cmds\"'.
>> 
>> What port does this fix?
> 
> devel/libghthash is the port broken if you end up with a better fix,
> please just commit.

It looks like the configure script in that port is generated with macros
from a newer version of libtool than the ltmain.sh script.  I suggest to
fix the port instead by running libtoolize.  Because our libtool is an
even more recent version this also requires running aclocal and autoconf.
There's also a warning during configure about the 'missing' script being
out of date so also run automake.

Patch attached.  Pietro, can you approve it?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: libghthash.patch
Type: text/x-patch
Size: 670 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20140222/d4879d68/attachment.bin>