svn commit: r365735 - in head/games: . prboom-plus

John Marino freebsd.contact at marino.st
Mon Aug 25 13:59:35 UTC 2014


On 8/25/2014 15:55, Adam Weinberger wrote:
> On 25 Aug, 2014, at 9:52, John Marino <freebsd.contact at marino.st> wrote:
> 
>> On 8/25/2014 15:43, Adam Weinberger wrote:
>>> On 25 Aug, 2014, at 5:32, Alexey Dokuchaev <danfe at FreeBSD.org>
>>> wrote:
>>>> COMMENT line is wrong. :)
>>>
>>> Because it starts with an article? I’d posit that that article
>>> improves readability of this particular COMMENT.
>>
>> Yes, because it starts with an article.   We've been instructed to
>> remove them unconditionally.
>> Hundreds of ports have comments equivalent to "Fork of the doom game
>> engine prboom", so it's not special in any way.
>>
>> Unfortunately portlint doesn't check for this.  I'd add this to the
>> current catch-all portlint rule PR.
> 
> Guys, if it’s not right, please just fix it!
> 

It's more than that -- Let's say you really think starting with "A " is
essential not matter what the rule is, then it makes sense to discuss it
to prevent it in the future.  It's not being lazy or critical, it's
educating.  At least I believe that is the intent.

John


More information about the svn-ports-all mailing list