svn commit: r365590 - in head/cad/spice: . files

[Hiroki Sato]

John Marino <freebsd.contact at marino.st> wrote
  in <53F663B2.3000800 at marino.st>:

fr> On 8/21/2014 21:41, Hiroki Sato wrote:
fr> > Author: hrs
fr> > Date: Thu Aug 21 19:41:06 2014
fr> > New Revision: 365590
fr> > URL: http://svnweb.freebsd.org/changeset/ports/365590
fr> > QAT: https://qat.redports.org/buildarchive/r365590/

...

fr> I'm sorry, but using freebsd-specific <bsd.prog.mk> in a ports vendor
fr> makefile is NOT an improvement and frankly puts the build at risk on
fr> DragonFly.
fr>
fr> I wish there was a rule that ports should not use system make fragments.
fr>  This is not a good practice.  This port had a perfectly working and
fr> generic makefile before.
fr>
fr> There's a good chance this just broke spice on DragonFly as the system
fr> make file these are different.

 I can understand that vendor's Makefile should be platform-neutral,
 but I do not think there is advantage to maintain
 ${FILESDIR}/Makefile in a way not to use FreeBSD-specific stuff
 because it is used only by the port.  Should we care about build on
 DragonFly?

-- Hiroki
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20140822/d0f08c3d/attachment.sig>